Move disabling of rc overrides up to RC_Channel base class #9275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will stop situations like we currently have where the MANUAL_CONTROL GCS mavlink packets can still affect the vehicle Also resolves an issue where has_new_overrides may not be set appropriately
This shouldn't really in in RC_Channels - when we move the mavlink packet handling up to the GCS_MAVLink base class we should move this into there.
Use RC_Channels::has_active_overrides() instead
peterbarker
force-pushed
the
rewrite-read-radio-failsafe
branch
from
cf2e706
to
2a0f7bd
Compare
OXINARF
reviewed
Sep 4, 2018
| want_speed = 2.0 | ||
| print("Speed=%f want=<%f" % (m.groundspeed, want_speed)) | ||
| if m.groundspeed < want_speed: | ||
| break |
There was a problem hiding this comment.
Doesn't it make more sense to compare the actual PWM value like was done before?
There was a problem hiding this comment.
The subsequent test is checking the vehicle's speed, so this is consistent.
| return; | ||
| } | ||
|
|
||
| // Nobody ever talks to us. Log an error and enter failsafe. |
There was a problem hiding this comment.
I want more of these comments in our code! 🤣
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows rc overrides to be disabled on a Rover with an aux switch (as they can on Copter).